feat: unify error interface & upgrade got #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change we are not any longer returning or logging the raw HTTPError that could contain auth credentials. Instead we are wrapping those errors. As part of those changes I also had to bump Got to the latest version. BREAKING CHANGE: Errors have different properties
philnash
suggested changes
Apr 22, 2020
There was a problem hiding this comment.
This is a big update. I guess this should be a major version bump because of the new error message, though that is a good change.
The three comments I left aren't too much of a complaint. I think the most important one is the error that gets swallowed, would be good to straighten that out if possible.
dkundel
force-pushed
the
dkundel/upgrade-got
branch
from
a6cebe8 to
41305ae
Compare
philnash
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we are not any longer returning or logging the raw HTTPError that could contain
auth credentials. Instead we are wrapping those errors. As part of those changes I also had to bump
Got to the latest version.
BREAKING CHANGE: Errors have different properties
Contributing to Twilio